Bug in TBtnBmp [Solved]

[Antonio Linares]

Enrico,

Yes, I saw the two times also.

Please lets try this obvious change:

DrawTransBmp( ::hDC, hBmp, oBmpRect:nTop + 1, oBmpRect:nLeft + 1, oBmpRect:nWidth, oBmpRect:nHeight )

and let me know if you get part of the border back, thanks

[Enrico Maria Giordano]

Antonio,

Enrico,

Yes, I saw the two times also.

No, they are four places to fix. Look carefully.

EMG

[Enrico Maria Giordano]

Antonio,

Please lets try this obvious change:

DrawTransBmp( ::hDC, hBmp, oBmpRect:nTop + 1, oBmpRect:nLeft + 1, oBmpRect:nWidth, oBmpRect:nHeight )

and let me know if you get part of the border back, thanks

No, sorry.

EMG

[Antonio Linares]

Enrico,

Ok, I am going to review it in deep and see whats going on.

Thanks for your great feedback, my friend

[Enrico Maria Giordano]

Antonio,

you're welcome. It's our interest to keep Fivewin healty!

EMG

[Antonio Linares]

Enrico,

This code (in both places) seems to fix the border issue

Code: Select all

      if ! Empty( hBmp )
         if ::lBmpTransparent
            if SetAlpha() .and. ::aAlpha[ nBtn ]
               ABPaint( ::hDC, oBmpRect:nLeft, oBmpRect:nTop, hBmp, ::nAlphaLevel() )
            else
               DrawTransBmp( ::hDC, hBmp, oBmpRect:nTop, oBmpRect:nLeft, oBmpRect:nWidth, oBmpRect:nHeight )
            endif
         else
            DrawTransBmp( ::hDC, hBmp, oBmpRect:nTop, oBmpRect:nLeft, oBmpRect:nWidth, oBmpRect:nHeight )
         endif
         if ::lBorder
            WndBox( ::hDC, 0, 0, ::nHeight - 1, ::nWidth - 1 )
         endif   
      endif

I appreciate your comments, thanks

[Antonio Linares]

Enrico,

To me, this is the right fix (I am testing FWH\samples\testbtnb.prg).

Code: Select all

      if ! Empty( hBmp )
         if ::lBmpTransparent
            if SetAlpha() .and. ::aAlpha[ nBtn ]
               ABPaint( ::hDC, oBmpRect:nLeft, oBmpRect:nTop, hBmp, ::nAlphaLevel() )
            else
               DrawTransBmp( ::hDC, hBmp, oBmpRect:nTop, oBmpRect:nLeft + 2, oBmpRect:nWidth, oBmpRect:nHeight )
            endif
         else
            DrawTransBmp( ::hDC, hBmp, oBmpRect:nTop, oBmpRect:nLeft + 2, oBmpRect:nWidth, oBmpRect:nHeight )
         endif
         if ::lBorder
            WndBox( ::hDC, 0, 0, ::nHeight - 1, ::nWidth - 1 )
         endif   
      endif
 

Anyhow, we may need to test it in deep and see if there are some side effects.

[Enrico Maria Giordano]

Antonio,

I'm lost in the changes.

Can you send me the fixed btnbmp.prg to my email, please?

EMG

[Antonio Linares]

Enrico,

xharbour and Borland, right ?

(I know you can't move to harbour yet)

[Antonio Linares]

Enrico,

I have sent you the libs and btnbmp.prg, thanks

[Enrico Maria Giordano]

Antonio,

thank you. Unfortunately the result is... ugly!

EMG

[Antonio Linares]

Enrico,

I am testing FWH\samples\testbtnb.prg and it looks fine.

What example are you testing ?

[Antonio Linares]

[Enrico Maria Giordano]

Antonio,

Enrico,

I am testing FWH\samples\testbtnb.prg and it looks fine.

What example are you testing ?

The simple one that I've already reported:

Code: Select all

#include "Fivewin.ch"


FUNCTION MAIN()

    LOCAL oDlg

    DEFINE DIALOG oDlg;
           SIZE 800, 600

    @ 10, 10 BTNBMP SIZE 20, 20;
             FILE "c:\fwh\bitmaps\open.bmp";
             ADJUST

    ACTIVATE DIALOG oDlg;
             CENTER

    RETURN NIL

EMG

[Enrico Maria Giordano]

Antonio,

As you can see, there is no border anymore (it was there using the previous FWH release).

EMG