xbrowse required bug fixes !

Post Reply
User avatar
Antonio Linares
Site Admin
Posts: 37481
Joined: Thu Oct 06, 2005 5:47 pm
Location: Spain
Contact:

xbrowse required bug fixes !

Post by Antonio Linares »

After testing the code that we have published here:
http://forums.fivetechsupport.com/viewt ... =3&t=15935

we have detected some errors in Class TXBrowse that must be fixed:

1) Method End() has to be renamed as Destroy(). It was wrong. And finally call return Super:Destroy()

2) This code is needed in Method CreateButtons() before the @ ..., ... :

Code: Select all

 
      if ::oBtnList != nil
         ::oBtnList:End()
      endif   
      if ::oBtnElip != nil
         ::oBtnElip:End()
      endif  
 
3) In function function TXBrows() the browse is not destroyed:

Code: Select all

   if ValType( bChild ) == 'B'
      bXBr:End()
      bXBr := bChild
   endif
 
4) PalBmpFree() is not properly working. This function should be added:

Code: Select all

 
function PalBmpFree( hBmp, hPal )

   DeleteObject( hBmp )
   DeleteObject( hPal )

return nil
 
regards, saludos

Antonio Linares
www.fivetechsoft.com
User avatar
Otto
Posts: 4470
Joined: Fri Oct 07, 2005 7:07 pm
Contact:

Re: xbrowse required bug fixes !

Post by Otto »

Hello Antonio,

what version of xBrowse is affected ?
Thanks in advance
Otto
********************************************************************
mod harbour - Vamos a la conquista de la Web
modharbour.org

********************************************************************
User avatar
Antonio Linares
Site Admin
Posts: 37481
Joined: Thu Oct 06, 2005 5:47 pm
Location: Spain
Contact:

Re: xbrowse required bug fixes !

Post by Antonio Linares »

Otto,

The Method End(), that must be Destroy(), affects to all xbrowse versions.
The PalBmpFree() may also affect to all xbrowse versions.

The others two, can't say the exact version right now. Better look in your xbrowse.prg code for those sections. Thanks,
regards, saludos

Antonio Linares
www.fivetechsoft.com
User avatar
Antonio Linares
Site Admin
Posts: 37481
Joined: Thu Oct 06, 2005 5:47 pm
Location: Spain
Contact:

Re: xbrowse required bug fixes !

Post by Antonio Linares »

Another bug fixed:

Code: Select all

METHOD End() CLASS TXBrwColumn

...

   for nFor := 1 to Len( ::aBitmaps )
      PalBmpFree( ::aBitmaps[ nFor, BITMAP_HANDLE ], ::aBitmaps[ nFor, BITMAP_PALETTE ] )
   next

return nil
 
regards, saludos

Antonio Linares
www.fivetechsoft.com
Patrizio
Posts: 90
Joined: Wed Nov 07, 2007 8:56 am
Location: Italy
Contact:

Re: xbrowse required bug fixes !

Post by Patrizio »

Good :D
Davide
Posts: 190
Joined: Tue Mar 14, 2006 1:59 am
Location: Italy

Re: xbrowse required bug fixes !

Post by Davide »

Antonio,
do you plan to release 9.06 before the month end ?
(I'd prefer having the bugfixes already included in the standard lib rather than including another obj)
Thanks,
Davide
User avatar
Antonio Linares
Site Admin
Posts: 37481
Joined: Thu Oct 06, 2005 5:47 pm
Location: Spain
Contact:

Re: xbrowse required bug fixes !

Post by Antonio Linares »

Davide,

We are working hard to deliver 9.06 before end of this month.

But we can't promise it yet :-)
regards, saludos

Antonio Linares
www.fivetechsoft.com
Post Reply